Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): remove unnecessary variable #4608

Merged
merged 4 commits into from Aug 13, 2021
Merged

fix(storage): remove unnecessary variable #4608

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
954b8f0
fix(storage): remove unnecessary variable
BrennaEpp Aug 13, 2021
0bc41ad
Merge branch 'master' into remove-envhost
BrennaEpp Aug 13, 2021
e0a8ec4
Merge branch 'master' into remove-envhost
BrennaEpp Aug 13, 2021
c02ced7
Merge branch 'master' into remove-envhost
BrennaEpp Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions storage/storage.go
View file
Open in desktop
Expand Up @@ -90,8 +90,6 @@ type Client struct {
raw *raw.Service
// Scheme describes the scheme under the current host.
scheme string
// EnvHost is the host set on the STORAGE_EMULATOR_HOST variable.
envHost string
// ReadHost is the default host used on the reader.
readHost string
}
Expand Down Expand Up @@ -152,7 +150,6 @@ func NewClient(ctx context.Context, opts ...option.ClientOption) (*Client, error
hc: hc,
raw: rawService,
scheme: scheme,
envHost: host,
readHost: readHost,
}, nil
}
Expand Down
3 changes: 0 additions & 3 deletions storage/writer.go
View file
Open in desktop
Expand Up @@ -125,9 +125,6 @@ func (w *Writer) open() error {
if w.MD5 != nil {
rawObj.Md5Hash = base64.StdEncoding.EncodeToString(w.MD5)
}
if w.o.c.envHost != "" {
w.o.c.raw.BasePath = fmt.Sprintf("%s://%s", w.o.c.scheme, w.o.c.envHost)
}
call := w.o.c.raw.Objects.Insert(w.o.bucket, rawObj).
Media(pr, mediaOpts...).
Projection("full").
Expand Down