Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery/storage/managedwriter): improve protobuf support #4589

Merged
merged 14 commits into from Aug 16, 2021

Commits on Aug 10, 2021

  1. feat(bigquery/storage/managedwriter): improve protobuf support

    After some ongoing discussions with the Storage API team, this PR
    improves support for proto2/proto3 syntax in protocol buffer code.
    
    * Updates testdata so that we have a proto2 and proto3 form of
      our SimpleMessage data.
    
    * Add reference schemas to testdata.
    
    * Updates proto conversion code in the adapt package so it's creating
      proto2 messages by default.  The code paths for doing proto3
      conversions are present, but not exported yet as the storage API
      doesn't properly handle proto3 expectations for conversion. Namely,
      conversion doesn't properly account for default values and use of
      wrapper types.
    
    * Adds benchmarks for dynamic schema generation and static
      serialization, to aid in some internal discussions.
    shollyman committed Aug 10, 2021
    Copy the full SHA
    5cb0a60 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    7893ad7 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    4b4b9eb View commit details
    Browse the repository at this point in the history
  4. goimports on proto outputs

    shollyman committed Aug 10, 2021
    Copy the full SHA
    d8c26a4 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    4f8716c View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. goimports again

    shollyman committed Aug 11, 2021
    Copy the full SHA
    e58a850 View commit details
    Browse the repository at this point in the history
  2. add a sparse benchmark case

    shollyman committed Aug 11, 2021
    Copy the full SHA
    9d676f0 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Copy the full SHA
    a3f659e View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    2d87e1e View commit details
    Browse the repository at this point in the history
  3. fix comment typo

    shollyman committed Aug 12, 2021
    Copy the full SHA
    33af806 View commit details
    Browse the repository at this point in the history
  4. update test

    shollyman committed Aug 12, 2021
    Copy the full SHA
    db95a76 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    d2b70f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Copy the full SHA
    75ca7fd View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    a597089 View commit details
    Browse the repository at this point in the history