Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal/gapicgen): exec Stdout already set #4509

Merged
merged 2 commits into from Jul 28, 2021
Merged

fix(internal/gapicgen): exec Stdout already set #4509

merged 2 commits into from Jul 28, 2021

Commits on Jul 28, 2021

  1. fix(internal/gapicgen): exec Stdout already set 

    This error was occuring because stdout was being set by some
calling locations which violates Command.Output usage. This
refactors code to never set stdout. I also added some more debug
info of logging the command output which can be useful in the case
of failures.
    @codyoss
    codyoss committed Jul 28, 2021
    Copy the full SHA
    b0a805f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-stdout-err

    @codyoss
    codyoss committed Jul 28, 2021
    Copy the full SHA
    1fc4ba0 View commit details
    Browse the repository at this point in the history