feat(spanner/spansql): fix (date|timestamp) comparison parse. #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2021 10:57
This fixes case when query has `date = @date` or `timestamp = @timestamp` case. Since date and timestamp are not reserved keyword, they can be used as ID
googleapis#4457 made unstable SQL string, and fail test sometimes like this. ``` --- FAIL: TestSQL (0.00s) sql_test.go:410: {{false [A] [{Table map[FORCE_INDEX:Idx GROUPBY_SCAN_OPTIMIZATION:TRUE]}] {4 B b <nil>} [] [] []} [] <nil> <nil>}.SQL() wrong. got SELECT A FROM Table@{GROUPBY_SCAN_OPTIMIZATION=TRUE,FORCE_INDEX=Idx} WHERE B = @b want SELECT A FROM Table@{FORCE_INDEX=Idx,GROUPBY_SCAN_OPTIMIZATION=TRUE} WHERE B = @b ``` Because map range result is unstable. This PR makes the SQL output stable by sorting the Hints keys.
google-cla
bot
added
the
cla: yes
|
The first one is imcomplete, so I'll modify this PR only include failed test.
So, I close this and made new PR #4473 only include fix test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two nit things.
Second was made unstable tests and SQL output by #4457 (sorry.)