Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigtable): fix #4338 by removing obsolete with block #4353

Merged
merged 2 commits into from Jun 30, 2021
Merged

fix(bigtable): fix #4338 by removing obsolete with block #4353

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a81bdd0
fix(bigtable): fix #4338 by removing obsolete with block
crwilcox Jun 30, 2021
f81776c
Merge branch 'master' into remove-obsolete-option
crwilcox Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions bigtable/bigtable.go
View file
Open in desktop
Expand Up @@ -79,9 +79,7 @@ func NewClientWithConfig(ctx context.Context, project, instance string, config C
option.WithGRPCConnectionPool(4),
// Set the max size to correspond to server-side limits.
option.WithGRPCDialOption(grpc.WithDefaultCallOptions(grpc.MaxCallSendMsgSize(1<<28), grpc.MaxCallRecvMsgSize(1<<28))),
// TODO(grpc/grpc-go#1388) using connection pool without WithBlock
// can cause RPCs to fail randomly. We can delete this after the issue is fixed.
option.WithGRPCDialOption(grpc.WithBlock()))
)
// Attempts direct access to spanner service over gRPC to improve throughput,
// whether the attempt is allowed is totally controlled by service owner.
o = append(o, internaloption.EnableDirectPath(true))
Expand Down