Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsublite)!: hide CreateSubscriptionOption.apply #4344

Merged
merged 1 commit into from Jun 29, 2021
Merged

fix(pubsublite)!: hide CreateSubscriptionOption.apply #4344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions pubsublite/admin.go
View file
Open in desktop
Expand Up @@ -165,14 +165,14 @@ type createSubscriptionSettings struct {

// CreateSubscriptionOption is an option for AdminClient.CreateSubscription.
type CreateSubscriptionOption interface {
Apply(*createSubscriptionSettings)
apply(*createSubscriptionSettings)
}

type startingOffset struct {
backlogLocation BacklogLocation
}

func (so startingOffset) Apply(settings *createSubscriptionSettings) {
func (so startingOffset) apply(settings *createSubscriptionSettings) {
settings.backlogLocation = so.backlogLocation
}

Expand All @@ -190,7 +190,7 @@ func StartingOffset(location BacklogLocation) CreateSubscriptionOption {
func (ac *AdminClient) CreateSubscription(ctx context.Context, config SubscriptionConfig, opts ...CreateSubscriptionOption) (*SubscriptionConfig, error) {
var settings createSubscriptionSettings
for _, opt := range opts {
opt.Apply(&settings)
opt.apply(&settings)
}

subsPath, err := wire.ParseSubscriptionPath(config.Name)
Expand Down