New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release spanner 1.22.0 #4339
chore: release spanner 1.22.0 #4339
Conversation
@olavloite Interesting. Why #4336 does not appear in this release? I'd like to release the tagging work together. |
Hmm... That's strange. The commit is in the release, but it does not show up in the list of changes. I think that is because the commit got a non-conforming commit message: https://github.com/googleapis/google-cloud-go/pull/4336/commits (It starts with I guess the best solution in this case is to manually edit the release notes. |
@codyoss I can't push my change to this PR. Is there any way that I can update the release note ( |
It's interesting that I did it successfully via Github UI by directly editing the file. But when I did update the file locally, I failed to push my change. What I have done is: gh pr checkout 4339
vim spanner/CHANGES.md
git add spanner/CHANGES.md
git commit
git push origin HEAD:refs/pull/4339/head I got the error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like it is all good now, lmk if my assistance is still needed. |
馃 Release is at https://github.com/googleapis/google-cloud-go/releases/tag/spanner/v1.22.0 馃尰 |
馃 I have created a release *beep* *boop*
1.22.0 (2021-06-30)
Features
This PR was generated with Release Please. See documentation.