Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery): update streaming insert error test #4321

Merged
merged 2 commits into from Jun 28, 2021
Merged

fix(bigquery): update streaming insert error test #4321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cd8600
fix(bigquery): update streaming insert error test
shollyman Jun 25, 2021
0a8a837
Merge branch 'master' into fix-error-test
tbpg Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions bigquery/integration_test.go
View file
Open in desktop
Expand Up @@ -1378,9 +1378,11 @@ func TestIntegration_InsertErrors(t *testing.T) {
if !ok {
t.Errorf("Wanted googleapi.Error, got: %v", err)
}
want := "Request payload size exceeds the limit"
if !strings.Contains(e.Message, want) {
t.Errorf("Error didn't contain expected message (%s): %s", want, e.Message)
if e.Code != http.StatusRequestEntityTooLarge {
want := "Request payload size exceeds the limit"
if !strings.Contains(e.Message, want) {
t.Errorf("Error didn't contain expected message (%s): %#v", want, e)
}
}
// Case 2: Very Large Request
// Request so large it gets rejected by intermediate infra (3x 10MB rows)
Expand Down