New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsublite): support seek subscription in AdminClient #4316
Conversation
@codyoss, @tbpg - please review this API change. I couldn't find other examples of handwritten libraries exposing operation polling. We want to allow waiting for the operation to be optional, as users may want it to be asynchronous in most cases. Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, Looks good overall though!
SeekSubscription
performs an out-of-band seek for a subscription to a specified target. AddsSeekSubscriptionOperation
, which wraps the auto-generated gapic type for polling the seek operation.