Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub): retry GOAWAY errors #4313

Merged
merged 7 commits into from Jun 29, 2021
Merged

fix(pubsub): retry GOAWAY errors #4313

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62447b8
fix(pubsub): retry GOAWAY errors
hongalex Jun 24, 2021
4604aec
Merge branch 'master' into fix-pubsub-goaway
hongalex Jun 24, 2021
bc958e5
add missing return
hongalex Jun 24, 2021
1608409
Merge branch 'fix-pubsub-goaway' of github.com:hongalex/google-cloud-…
hongalex Jun 24, 2021
0c66c8f
Merge branch 'master' into fix-pubsub-goaway
hongalex Jun 29, 2021
a92ada3
update error message checking
hongalex Jun 29, 2021
ad044d0
Merge branch 'fix-pubsub-goaway' of github.com:hongalex/google-cloud-…
hongalex Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions pubsub/service.go
View file
Open in desktop
Expand Up @@ -62,6 +62,14 @@ func (r *defaultRetryer) Retry(err error) (pause time.Duration, shouldRetry bool
return r.bo.Pause(), true
}
return 0, false
case codes.Unknown:
// Retry GOAWAY, see https://github.com/googleapis/google-cloud-go/issues/4257.
isGoaway := strings.Contains(s.Message(), "closing error reading from server: EOF") &&
Copy link
Contributor

@tmdiep tmdiep Jun 29, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking: does the error message contain exactly "closing error reading from server..."? I looked at the linked issue and that phrase isn't prefixed by "closing", so it may not match.

strings.Contains(s.Message(), "received prior goaway")
if isGoaway {
return r.bo.Pause(), true
}
return 0, false
default:
return 0, false
}
Expand Down