fix(pubsublite)!: do not expose apply for CreateSubscriptionOption #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: pubsublite
google-cla
bot
added
the
cla: yes
|
WANT_LGTM=any Sorry, just noticed this as I was doing a final pass through the API surface. |
|
apidiff detected a breaking change. Can we suppress/ignore it for this change? |
tmdiep
force-pushed
the
create_subs_option
branch
from
ff70c1a
to
f14564c
Compare
tmdiep
changed the title
tmdiep
force-pushed
the
create_subs_option
branch
from
f14564c
to
3f68bd5
Compare
tmdiep
changed the title
|
Replacement (tests pass): #4344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
createSubscriptionSettingsparameter is not public, also hide theapply()func.