Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): fix Writer.ChunkSize validation #4255

Merged
merged 2 commits into from Jun 14, 2021
Merged

fix(storage): fix Writer.ChunkSize validation #4255

merged 2 commits into from Jun 14, 2021

Commits on Jun 14, 2021

  1. fix(storage): fix Writer.ChunkSize validation 

    Since w.opened is set to true before this validation currently,
subsequent calls to Writer.Close will deadlock. There is no
reason not to do this check first before opening the pipe.

Thanks to @dt for pointing this out.

Updates googleapis#4167
    @tritone
    tritone committed Jun 14, 2021
    Copy the full SHA
    4ea45f1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into chunksize-fix

    @tritone
    tritone committed Jun 14, 2021
    Copy the full SHA
    b8695d0 View commit details
    Browse the repository at this point in the history