fix(bigtable/bttest): fix locking bug in DropRowRange #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DropRowRange's locking is inconsistent with the rest of bttest googleapis#2600 ModifyColumnFamilies demonstrates the correct pattern: - Use the server global mutex to reference the table by name - Use the table's mutex to guard data reads and writes. The existing implementation can data race if another concurrently running method (such as SampleRowKeys) has already dropped the server mutex and acquired the table mutex. Nothing then prevents DropRowRange from mutating table data during a Sample or Scan.
dragonsinth
requested review from
crwilcox,
kolea2,
tritone and
a team
as code owners
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigtable
|
Thanks very much for the fix here! I'm going to close in favor of #4207 which includes a test that reproduces the issue as well. |
|
Sweet! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DropRowRange's locking is inconsistent with the rest of bttest
#2600
ModifyColumnFamilies demonstrates the correct pattern:
The existing implementation can data race if another concurrently running method (such as SampleRowKeys)
has already dropped the server mutex and acquired the table mutex. Nothing then prevents DropRowRange
from mutating table data during a Sample or Scan.