storage: make Writer.CloseWithError block until writer exits #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: storage
Writer.Close blocks on w.donec to return only after the spawned writer goroutine has exited. Previously CloseWithError did not block on this channel however, meaning it could return while the writer goroutine was still running, which could then lead to a caller e.g. closing the underlying Client, leading to a crash in the still-running goroutine. This adds the same block on the channel to CloseWithError to ensure that however a caller closes a Writer, it is fully closed when the close method returns and that caller can safely Close the client.
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writer.Close blocks on w.donec to return only after the spawned writer goroutine
has exited. Previously CloseWithError did not block on this channel however, meaning
it could return while the writer goroutine was still running, which could then lead
to a caller e.g. closing the underlying Client, leading to a crash in the still-running
goroutine.
This adds the same block on the channel to CloseWithError to ensure that however a
caller closes a Writer, it is fully closed when the close method returns and that
caller can safely Close the client.
Fixes #4167.