Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal/gapicgen): use correct region tags for gensnippets #4022

Merged
merged 3 commits into from Apr 29, 2021
Merged

fix(internal/gapicgen): use correct region tags for gensnippets #4022

merged 3 commits into from Apr 29, 2021

Commits on Apr 29, 2021

  1. fix(internal/gapicgen): use correct region tags 

    A side effect of this is that only methods that correspond to RPCs get
region tags.

I changed the error handling so any snippet issues are only warnings and
don't log.Fatal.

I deleted and regenerated all of the snippets, which led to non-Method
snippets (e.g. NewClient) being deleted.
    @tbpg
    tbpg committed Apr 29, 2021
    Copy the full SHA
    af75ea9 View commit details
    Browse the repository at this point in the history

  2. chore: regenerate all snippets

    @tbpg
    tbpg committed Apr 29, 2021
    Copy the full SHA
    13f07ec View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into gensnippets

    @tbpg
    tbpg committed Apr 29, 2021
    Copy the full SHA
    a2d10fc View commit details
    Browse the repository at this point in the history