Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(internal/gapicgen): move cmdWrapper to new package #3951

Merged
merged 6 commits into from Apr 16, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Apr 15, 2021

Refactored so that the code could be used by the bot. This will
help have better debugging in logs.

Refactored so that the code could be used by the bot. This will
help have better debugging in logs.
@codyoss codyoss requested a review from tbpg April 15, 2021 21:57
@codyoss codyoss requested a review from a team as a code owner April 15, 2021 21:57
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2021
@codyoss
Copy link
Member Author

codyoss commented Apr 15, 2021

Wait for #3949, then will refactor those changes.

@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 15, 2021
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple comments (naming and log content).

internal/gapicgen/cmd/genbot/generate.go Outdated Show resolved Hide resolved
internal/gapicgen/command/command.go Outdated Show resolved Hide resolved
@codyoss codyoss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 16, 2021
@codyoss codyoss requested a review from tbpg April 16, 2021 15:52
@tbpg tbpg changed the title refactor(internal/gapicgen): move cmdWrapper to new packacke refactor(internal/gapicgen): move cmdWrapper to new package Apr 16, 2021
@codyoss codyoss merged commit 059ffbb into master Apr 16, 2021
@codyoss codyoss deleted the ref-command branch April 16, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants