Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsublite): increase default timeouts for publish and subscribe stream connections #3821

Merged
merged 2 commits into from Mar 16, 2021
Merged

fix(pubsublite): increase default timeouts for publish and subscribe stream connections #3821

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee9e182
fix(pubsublite): increase default timeouts for publish and subscribe …
tmdiep Mar 16, 2021
cb55de2
increase default timeout to 1 hr
tmdiep Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pubsublite/internal/wire/settings.go
View file
Open in desktop
Expand Up @@ -82,7 +82,7 @@ var DefaultPublishSettings = PublishSettings{
DelayThreshold: 10 * time.Millisecond,
CountThreshold: 100,
ByteThreshold: 1e6,
Timeout: 10 * time.Minute,
Timeout: 30 * time.Minute,
// By default set to a high limit that is not likely to occur, but prevents
// OOM errors in clients.
BufferedByteLimit: 1 << 30, // 1 GiB
Expand Down Expand Up @@ -146,7 +146,7 @@ type ReceiveSettings struct {
var DefaultReceiveSettings = ReceiveSettings{
MaxOutstandingMessages: 1000,
MaxOutstandingBytes: 1e9,
Timeout: 10 * time.Minute,
Timeout: 30 * time.Minute,
}

func validateReceiveSettings(settings ReceiveSettings) error {
Expand Down
4 changes: 2 additions & 2 deletions pubsublite/pscompat/settings.go
View file
Open in desktop
Expand Up @@ -106,7 +106,7 @@ var DefaultPublishSettings = PublishSettings{
DelayThreshold: 10 * time.Millisecond,
CountThreshold: 100,
ByteThreshold: 1e6,
Timeout: 60 * time.Second,
Timeout: 30 * time.Minute,
BufferedByteLimit: 1e8,
}

Expand Down Expand Up @@ -206,7 +206,7 @@ type ReceiveSettings struct {
var DefaultReceiveSettings = ReceiveSettings{
MaxOutstandingMessages: 1000,
MaxOutstandingBytes: 1e9,
Timeout: 60 * time.Second,
Timeout: 30 * time.Minute,
}

func (s *ReceiveSettings) toWireSettings() wire.ReceiveSettings {
Expand Down