Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(internal/godocfx): handle Markdown content #3816

Merged
merged 9 commits into from Mar 15, 2021
Merged

feat(internal/godocfx): handle Markdown content #3816

merged 9 commits into from Mar 15, 2021

Commits on Mar 15, 2021

  1. chore: copy go/doc into third_party 

    Copied from Go 1.16. I left out the testdata.
    @tbpg
    tbpg committed Mar 15, 2021
    Copy the full SHA
    a9967b2 View commit details
    Browse the repository at this point in the history

  2. feat(internal/godocfx): handle Markdown content 

    I added ToMarkdown to the doc package. I got the idea from @dmitshur,
who pointed me to http://golang.org/issues/34875.

Once the comment is converted to Markdown, it gets converted to HTML by
goldmark.

Future changes will:
* Add syntax highlighting for code blocks.
* Maybe add \` tags around code elements in the comment.
* Maybe support Markdown in other doc comments.
    @tbpg
    tbpg committed Mar 15, 2021
    Copy the full SHA
    3658b7b View commit details
    Browse the repository at this point in the history

  3. chore: goimports

    @tbpg
    tbpg committed Mar 15, 2021
    Copy the full SHA
    a642ed7 View commit details
    Browse the repository at this point in the history

  4. fix: ignore lint errors for third_party/go/doc

    @tbpg
    tbpg committed Mar 15, 2021
    Copy the full SHA
    ad786ea View commit details
    Browse the repository at this point in the history

  5. ci: ignore more in vet

    @tbpg
    tbpg committed Mar 15, 2021
    Copy the full SHA
    fd689c1 View commit details
    Browse the repository at this point in the history

  6. test: update comment_test, remove doc_test

    @tbpg
    tbpg committed Mar 15, 2021
    Copy the full SHA
    9f6af82 View commit details
    Browse the repository at this point in the history

  7. test: header test ignore new third_party code

    @tbpg
    tbpg committed Mar 15, 2021
    Copy the full SHA
    4010c60 View commit details
    Browse the repository at this point in the history

  8. chore: 1.16 build tags

    @tbpg
    tbpg committed Mar 15, 2021
    Copy the full SHA
    88ee14f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into markdown

    @tbpg
    tbpg committed Mar 15, 2021
    Copy the full SHA
    4505be0 View commit details
    Browse the repository at this point in the history