feat(spansql/spannertest): support NOT IN clause #3716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
See #3724 instead. |
|
Ok, thanks! Sounds better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Fixes #3715
Note
I made the function return early when it finds "IN" as well as "NOT IN", though "IN" can be already skipped in the following codes. That's because I suppose it's more readable to notice that "IN" including "NOT IN" is out of the parsing scope of this function.
For the same point, I put this validation before
if tok.value == "NOT", not in this "if" statement.