Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner/spannertest): support queries in ExecuteSql #3640

Merged
merged 9 commits into from Feb 4, 2021

Commits on Feb 1, 2021

  1. fix(spanner/spannertest): support queries in ExecuteSql

    Normal queries from the Spanner client use the ExecuteStreamingSql method,
    while DML statements use ExecuteSql. This distinction was also built into
    spannertest where ExecuteSql would only support DML statements and required
    a transaction to be specified. The session pool however uses ExecuteSql to
    execute a simple `SELECT 1` query without specifying any transaction. This
    would cause a nil pointer dereference.
    
    This PR introduces support for queries in the ExecuteSql method. The current
    logic assumes that the statement is a query if the transaction is a single-
    use read-only transaction.
    
    Fixes #3639
    olavloite committed Feb 1, 2021
    1
    Copy the full SHA
    c284847 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    8a0f196 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    bf5f5ca View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Copy the full SHA
    36f77bb View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    68a4dea View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    a72b25a View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    39eb42c View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Copy the full SHA
    920fe12 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Copy the full SHA
    279268e View commit details
    Browse the repository at this point in the history