New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): support PublicAccessPrevention #3608
Merged
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b8fbd5a
feat(storage): support public access prevention
tritone 3a53cc0
Merge branch 'master' into bucket-pap
tritone df72fb1
update docs
tritone 8bc4324
make PublicAccessPrevention.String exported
tritone 0450509
use %s for String()
tritone 6e930be
replace default with unknown
tritone 071040e
Merge branch 'master' into bucket-pap
tritone 7d99085
Merge branch 'master' into bucket-pap
shaffeeullah 026aa80
Merge branch 'master' into bucket-pap
shaffeeullah 0eef114
Merge branch 'master' into bucket-pap
shaffeeullah add3fd6
Merge branch 'master' into bucket-pap
tritone 7dadea8
Merge branch 'master' into bucket-pap
shaffeeullah 3908c05
Merge branch 'master' into bucket-pap
shaffeeullah File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the naming of this field might be confusing. Public Access Prevention defaults to 'unspecified'. It will never hold a blank value. I'm trying to think of another option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on this one-- I was trying to follow https://google.aip.dev/126 but it suggests "unspecified" for a zero value. 😆 Suggestions welcome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went for "unknown" here instead.