Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging): add localIP and Cache fields to HTTPRequest conversion from proto #3600

Merged
merged 3 commits into from Jan 25, 2021
Merged

feat(logging): add localIP and Cache fields to HTTPRequest conversion from proto #3600

merged 3 commits into from Jan 25, 2021

Conversation

0xSage
Copy link
Contributor

@0xSage 0xSage commented Jan 22, 2021

Fix #3588

Changes:

  • Turned integration test back on for logadmin. According to previous comments, this may be flakey so I will closely monitor and debug.
  • Added fields LocalIP, CacheLookup, and CacheFillBytes back to httprequest conversion from proto to logging.httprequest

@0xSage 0xSage self-assigned this Jan 22, 2021
@0xSage 0xSage requested review from a team as code owners January 22, 2021 23:56
@product-auto-label product-auto-label bot added the api: logging Issues related to the Cloud Logging API. label Jan 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2021
@0xSage 0xSage added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jan 22, 2021
codyoss
codyoss approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xSage 0xSage added the automerge Merge the pull request once unit tests and other checks pass. label Jan 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit f93027b into master Jan 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix3588 branch January 25, 2021 18:56
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees

@0xSage 0xSage

Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logging: missing assignment in function "toHTTPRequest"
2 participants
@0xSage @codyoss