Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spannertest): support alter not null with non-string, non-bytes types #3596

Closed
wants to merge 2 commits into from
Closed

feat(spannertest): support alter not null with non-string, non-bytes types #3596

wants to merge 2 commits into from

Conversation

petercgrant
Copy link
Contributor

Adds support in spannertest for alter statements that change only not null constraints. This previously worked only for string or bytes columns.

@petercgrant petercgrant requested review from skuruppu and a team as code owners January 21, 2021 21:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jan 21, 2021
@dsymonds
Copy link
Contributor

Thanks, but I think this part of the code needs a bigger overhaul. I'll have a go at that this week, and that should subsume this.

@dsymonds
Copy link
Contributor

Superseded by #3616.

@dsymonds dsymonds closed this Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuruppu skuruppu Awaiting requested review from skuruppu

@dsymonds dsymonds Awaiting requested review from dsymonds

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petercgrant @dsymonds