New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigquery): add support for allowing Javascript UDFs to indicate determinism #3534
Merged
gcf-merge-on-green
merged 7 commits into
googleapis:master
from
shollyman:fr-routine-determinism
Jan 14, 2021
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c50be46
feat: add support for allowing Javascript UDFs to indicate determinism
shollyman 2bee86a
Merge branch 'master' into fr-routine-determinism
shollyman cdcecc6
Merge branch 'master' into fr-routine-determinism
shollyman 9dd2e17
ensure update can handle strings or the RoutineDeterminism custom type
shollyman 30cdfce
Merge branch 'master' into fr-routine-determinism
shollyman ce5503a
Merge branch 'fr-routine-determinism' of github.com:shollyman/google-…
shollyman 3326111
Merge branch 'master' into fr-routine-determinism
shollyman File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why panic instead of returning
error
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mimics the behavior of the converters in https://pkg.go.dev/cloud.google.com/go/internal/optional. All the other fields panic if you use incorrect type, so yielding a custom error for the one field seems a mismatch.