Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery): address possible panic due to offset checking in handleInsertErrors #3524

Merged
merged 8 commits into from Jan 12, 2021
Merged

fix(bigquery): address possible panic due to offset checking in handleInsertErrors #3524

merged 8 commits into from Jan 12, 2021

Commits on Jan 11, 2021

  1. fix: address possible panic due to offset checking in handleInsertErrors 

    External reporter identified case where improper bounds checking can
cause panic when comparing the index value from structured error
response.

Fixes: googleapis#3519
    @shollyman
    shollyman committed Jan 11, 2021
    Copy the full SHA
    3e94c9a View commit details
    Browse the repository at this point in the history

  2. refine error testing

    @shollyman
    shollyman committed Jan 11, 2021
    Copy the full SHA
    5730953 View commit details
    Browse the repository at this point in the history

  3. simplify type assertion

    @shollyman
    shollyman committed Jan 11, 2021
    Copy the full SHA
    2eea074 View commit details
    Browse the repository at this point in the history

  4. simplify test cases

    @shollyman
    shollyman committed Jan 11, 2021
    Copy the full SHA
    a95b72c View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. Merge branch 'master' into issue-3519-inserterrors

    @shollyman
    shollyman committed Jan 12, 2021
    Copy the full SHA
    f2f92c5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue-3519-inserterrors

    @shollyman
    shollyman committed Jan 12, 2021
    Copy the full SHA
    1d1a456 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into issue-3519-inserterrors

    @shollyman
    shollyman committed Jan 12, 2021
    Copy the full SHA
    bc1b6b9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into issue-3519-inserterrors

    @shollyman
    shollyman committed Jan 12, 2021
    Copy the full SHA
    1cc75fc View commit details
    Browse the repository at this point in the history