Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): Add support for RPC priority #3341

Merged
merged 12 commits into from Mar 31, 2021
Merged

feat(spanner): Add support for RPC priority #3341

merged 12 commits into from Mar 31, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Dec 3, 2020 •
edited

Adds support for setting a priority per RPC. This can be any read/query/update statement and it can be set for a commit RPC.

@olavloite
feat(spanner): add support for RPC priority
d3c965c 
Adds support for setting a priority per RPC. This can be any read/query/update
statement and it can be set for a commit RPC.
@olavloite
fix: fix ApplyAtLeastOnce + add tests
4ec3f48
@olavloite
fix: only include RequestOptions if necessary
3b1addd
@olavloite
fix: remove unnecessary blank line
04e7c64
@olavloite olavloite added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 3, 2020
@olavloite olavloite requested a review from a team as a code owner December 3, 2020 16:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Dec 3, 2020
@olavloite olavloite removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 26, 2021
@olavloite
Copy link
Contributor Author

@skuruppu and @larkee Please take a final look, this should now also be ready for merging.

hengfengli
hengfengli reviewed Mar 30, 2021
View reviewed changes
spanner/transaction.go Outdated Show resolved Hide resolved
hengfengli
hengfengli approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@larkee larkee merged commit 88cf097 into master Mar 31, 2021
@larkee larkee deleted the spanner-rpc-priority branch March 31, 2021 04:10
@yfuruyama yfuruyama mentioned this pull request Apr 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss left review comments

@hengfengli hengfengli hengfengli approved these changes

@skuruppu skuruppu skuruppu approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@olavloite @hengfengli @skuruppu @codyoss @larkee