New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsublite): assigning subscriber implementation #3238
Conversation
WANT_LGTM=@dpcollins-google for checking assigner and assigningSubscriber logic. |
92d9cd8
to
71ab99c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after changes from a pub/sub lite perspective, I'd prefer if you get someone familiar with go to review as well.
WANT_LGTM=@hongalex for Go, and also Dan doesn't have write access and can't approve anyway. |
assigningSubscriber
uses the Pub/Sub Lite partition assignment service to listen to its assigned partition numbers and dynamically add/removesinglePartitionSubscribers
.