New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pubsub): retry deadline exceeded errors in Acknowledge #3157
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
04e8149
fix(pubsub): retry deadline exceeded errors in Acknowledge
hongalex 3c5ec90
add comment about gapic handling unavailable
hongalex 427c964
handle context deadline exceeded errors as well
hongalex 73b1b43
add backoff to context deadline exceeded errors
hongalex c1dcb19
fix wording of comments (transparent over transient)
hongalex 8a45de8
Merge branch 'master' into pubsub-ack-retry
hongalex 2b31adb
Merge branch 'master' into pubsub-ack-retry
hongalex File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so if we got a deadline exceeded, this seems to be a sleep and return, but I'm not seeing the retry. I'd expect a continue if a retry of the Acknowledge() call on line 400 is the intent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the
gax.Sleep
call is to briefly pause before retrying theAcknowledge
call. The err checking on this line, and the other instance ofgax.Sleep
, is to see if the outer 3 minute context has finished or not. If so, the entire call will terminate sinceerr != nil
and the next line will returnnil
. Iferr == nil
here,Acknowledge
will be called again on the next iteration of the loop.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was misreading the logic, thanks for the clarification.