Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsublite): Disable integration tests for project id #3087

Merged
merged 2 commits into from Oct 27, 2020
Merged

fix(pubsublite): Disable integration tests for project id #3087

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7fa501
fix(pubsublite): Disable integration tests for project id
tmdiep Oct 26, 2020
1bcd4af
Merge branch 'master' into fix_tests
hongalex Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions pubsublite/integration_test.go
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@ package pubsublite
import (
"context"
"math/rand"
"strconv"
"testing"
"time"

Expand Down Expand Up @@ -50,6 +51,10 @@ func initIntegrationTest(t *testing.T) {
if testutil.ProjID() == "" {
t.Skip("Integration tests skipped. See CONTRIBUTING.md for details")
}
// The Pub/Sub Lite server will accept project ID or number by EOQ4, 2020.
if _, err := strconv.ParseInt(testutil.ProjID(), 10, 64); err != nil {
t.Skip("Integration tests skipped. Only project number currently supported.")
}
rng = testutil.NewRand(time.Now())
}

Expand Down