Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner/spansql): fix parsing of adjacent inline and leading comments #2851

Merged
merged 1 commit into from Sep 14, 2020
Merged

fix(spanner/spansql): fix parsing of adjacent inline and leading comments #2851

merged 1 commit into from Sep 14, 2020

Conversation

dsymonds
Copy link
Contributor

These should be in separate Comment entries, not combined:
Some INT64, -- comment #1
-- comment #2

@dsymonds dsymonds added the api: spanner Issues related to the Spanner API. label Sep 13, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 13, 2020
@olavloite olavloite changed the title spanner/spansql: fix parsing of adjacent inline and leading comments fix(spanner/spansql): fix parsing of adjacent inline and leading comments Sep 14, 2020
These should be in separate Comment entries, not combined:
	Some INT64,  -- comment 1
        -- comment 2
@dsymonds dsymonds merged commit cca8632 into googleapis:master Sep 14, 2020
@dsymonds dsymonds deleted the spansql-doc branch September 14, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants