Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workflows): start generating apiv1beta #2799

Merged
merged 1 commit into from Aug 31, 2020
Merged

feat(workflows): start generating apiv1beta #2799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/.repo-metadata-full.json
View file
Open in desktop
Expand Up @@ -838,5 +838,13 @@
"client_library_type": "generated",
"docs_url": "https://pkg.go.dev/cloud.google.com/go/webrisk/apiv1beta1",
"release_level": "beta"
},
"cloud.google.com/go/workflows/apiv1beta": {
"distribution_name": "cloud.google.com/go/workflows/apiv1beta",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiv1beta, not apiv1beta1? Generation works, so this seems correct, but wanted to confirm since this flows into package name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, apiv1beta. Historically if the pathing in googleapis does not contain a number suffix neither does our package here.

"description": "",
"language": "Go",
"client_library_type": "generated",
"docs_url": "https://pkg.go.dev/cloud.google.com/go/workflows/apiv1beta",
"release_level": "beta"
}
}
8 changes: 8 additions & 0 deletions internal/gapicgen/generator/config.go
View file
Open in desktop
Expand Up @@ -776,6 +776,14 @@ var microgenGapicConfigs = []*microgenConfig{
apiServiceConfigPath: "google/cloud/video/transcoder/v1beta1/transcoder_gapic.yaml",
releaseLevel: "beta",
},
{
inputDirectoryPath: "google/cloud/workflows/v1beta",
pkg: "workflows",
importPath: "cloud.google.com/go/workflows/apiv1beta",
gRPCServiceConfigPath: "google/cloud/workflows/v1beta/workflows_grpc_service_config.json",
apiServiceConfigPath: "google/cloud/workflows/v1beta/workflows_gapic.yaml",
releaseLevel: "beta",
},

// Non-Cloud APIs
{
Expand Down
102 changes: 102 additions & 0 deletions workflows/apiv1beta/doc.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.