fix(pubsublite): mitigate gRPC stream connection issues #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
|
This is a port of the logic in the Java lib (googleapis/java-pubsublite#1038), which has been tested internally for over a week. It seems to have eliminated the stream hanging issues since rollout. |
hongalex
approved these changes
Feb 1, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 8, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.2](https://www.github.com/googleapis/google-cloud-go/compare/pubsublite/v1.2.1...pubsublite/v1.2.2) (2022-02-08) ### Features * **pubsublite:** add C++ rules for Pub/Sub Lite ([3e7185c](https://www.github.com/googleapis/google-cloud-go/commit/3e7185c241d97ee342f132ae04bc93bb79a8e897)) ### Bug Fixes * **pubsublite:** mitigate gRPC stream connection issues ([#5382](https://www.github.com/googleapis/google-cloud-go/issues/5382)) ([8763ef3](https://www.github.com/googleapis/google-cloud-go/commit/8763ef3d2da18e8fed6e350aef76d26a135246c2)) ### Documentation * **pubsublite:** update comments for regional topics ([#5202](https://www.github.com/googleapis/google-cloud-go/issues/5202)) ([7805468](https://www.github.com/googleapis/google-cloud-go/commit/78054682770af3b35cb0002c3c34006ec36590ef)) This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates hanging streams by detecting idle streams and reconnecting after a timeout (default 10min for partition assignment streams, 2min for all others). If the user has specified a lower timeout in settings, this will be used for publish, subscribe and commit streams.
The
StreamIdleTimeris restarted when the client receives a response on the stream. The stream is reinitialized when the timeout expires. For publish and commit streams, the timeout will still expire even if there is no user activity.