fix(bigquery): address issue from job construction feature #5059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature As part of the changes for googleapis#5048 one callsite of getJobInternal was missed. Normally this would easily get identified due to the change in signature, but getJobInternal has a set of expected string arguments, followed by variadic string args. This got picked up by integration testing, but I failed to recall that presubmit doesn't run integration tests so it was caught after submit. Mostly this one's a cautionary tale for having a mix of mandatory and variadic functions that share the same type. Fixes: googleapis#5058
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
codyoss
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the changes for
#5048 one callsite of
getJobInternal was missed. Normally this would easily get identified
due to the change in signature, but getJobInternal has a set of expected
string arguments, followed by variadic string args. This got picked up
by integration testing, but I failed to recall that presubmit doesn't run
integration tests so it was caught after submit.
Mostly this one's a cautionary tale for having a mix of mandatory and
variadic functions that share the same type.
Fixes: #5058