Skip to content

Commit

Permalink
fix(bigquery): address one other callsite for the job construction fe…
Browse files Browse the repository at this point in the history
…ature (#5059)

As part of the changes for
#5048 one callsite of
getJobInternal was missed.  Normally this would easily get identified
due to the change in signature, but getJobInternal has a set of expected
string arguments, followed by variadic string args.  This got picked up
by integration testing, but I failed to recall that presubmit doesn't run
integration tests so it was caught after submit.

Mostly this one's a cautionary tale for having a mix of mandatory and
variadic functions that share the same type.

Fixes: #5058
  • Loading branch information
shollyman committed Nov 1, 2021
1 parent 1b81e60 commit 98779eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bigquery/job.go
Expand Up @@ -207,7 +207,7 @@ func (j *Job) Status(ctx context.Context) (js *JobStatus, err error) {
ctx = trace.StartSpan(ctx, "cloud.google.com/go/bigquery.Job.Status")
defer func() { trace.EndSpan(ctx, err) }()

bqjob, err := j.c.getJobInternal(ctx, j.jobID, j.location, "status", "statistics")
bqjob, err := j.c.getJobInternal(ctx, j.jobID, j.location, j.projectID, "status", "statistics")
if err != nil {
return nil, err
}
Expand Down

0 comments on commit 98779eb

Please sign in to comment.