feat(bigquery): allow construction of jobs from other projects #5048
Conversation
Adds a `JobfromProject()` method to allow users to get metadata from a job that was created within another project. Fixes: googleapis#4228
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
| // JobFromProject creates a Job which refers to an existing BigQuery job. The job | ||
| // need not have been created by this package, nor does it need to reside within the same | ||
| // project or location as the instantiated client. | ||
| func (c *Client) JobFromProject(ctx context.Context, projectID, jobID, location string) (j *Job, err error) { |
There was a problem hiding this comment.
This is fine to me. Another option would be to have a config struct here and let users selectively override particular parameters than what they have set with their client.
There was a problem hiding this comment.
This pattern is used mostly because its in line with how we expose similar out-of-project resources like datasets. There's a minor preposition inconsistency though, in jobs we do JobFrom, but datasets are DatasetInProject. Seemed better to be consistent with the other job constructor names.
Other callsites that reference the client's projectID directly is job insertion, either the standard jobs.insert or the optimized jobs.query path. There's other things like dataset iterator Datasets(), but under the hood it calls DatasetsInProject() which allows remote enumeration. |
|
Getting this to a unit test is surprisingly annoying given the lack of intermediate interfaces, so I wrote a small integration test for now. |
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
…ature As part of the changes for googleapis#5048 one callsite of getJobInternal was missed. Normally this would easily get identified due to the change in signature, but getJobInternal has a set of expected string arguments, followed by variadic string args. This got picked up by integration testing, but I failed to recall that presubmit doesn't run integration tests so it was caught after submit. Mostly this one's a cautionary tale for having a mix of mandatory and variadic functions that share the same type. Fixes: googleapis#5058
…ature (#5059) As part of the changes for #5048 one callsite of getJobInternal was missed. Normally this would easily get identified due to the change in signature, but getJobInternal has a set of expected string arguments, followed by variadic string args. This got picked up by integration testing, but I failed to recall that presubmit doesn't run integration tests so it was caught after submit. Mostly this one's a cautionary tale for having a mix of mandatory and variadic functions that share the same type. Fixes: #5058
Adds a
JobfromProject()method to allow users to get metadata from ajob that was created within another project.
Fixes: #4228