Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub): add methods to allow retrieval of topic/sub config names #4953

Merged
merged 12 commits into from Oct 7, 2021
Merged

fix(pubsub): add methods to allow retrieval of topic/sub config names #4953

merged 12 commits into from Oct 7, 2021

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Oct 6, 2021 •
edited

Similar to Topic and Subscription, add methods ID() and String() (fully qualified name) to retrieve the name of topic and subscriptions. These methods will work only when the config is returned by the server, and will return empty strings if the config is constructed by the user.

Fixes #4952

@hongalex hongalex requested review from a team as code owners October 6, 2021 01:49
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Oct 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2021
@hongalex
use cmpopts.IgnoreUnexported for config comparisons
27b02dd
@hongalex
Merge branch 'master' into fix-resource-config-list-name
3de77f8
@hongalex
remove extra check for config
78741f6
@hongalex
Merge branch 'fix-resource-config-list-name' of github.com:hongalex/g…
def40c5 
…oogle-cloud-go into fix-resource-config-list-name
@hongalex
fix expiration policy test check
0dd6aba
@hongalex
fix expiration policy test check
182f443 
Change-Id: I5f6c3098464a214cbe8281417192bfa52122f21c
@hongalex
Merge branch 'fix-resource-config-list-name' of github.com:hongalex/g…
2b1a6b7 
…oogle-cloud-go into fix-resource-config-list-name

Change-Id: I59ef393754b4502d8f9bf4ab9195d0f35fd6347b
@hongalex
add ignore unexported option to UpdateSub test
1a8fb9f
@hongalex
fix update subscription exp policy test
5565e53 
Change-Id: I2809bfaab6a2547c9fbc1ddb055359882262b544
@hongalex
fix message storage policy check
2bdaef5 
Change-Id: Ie09da85759bc04be3867e4f6006cfcde12a41f34
@hongalex hongalex mentioned this pull request Oct 7, 2021
Merged
codyoss
codyoss approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongalex hongalex merged commit bff5b1c into googleapis:master Oct 7, 2021
@hongalex hongalex deleted the fix-resource-config-list-name branch October 7, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub: can't retrieve name from topic/sub config list method
2 participants
@hongalex @codyoss