Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): support nullable params and geography params #4225

Merged
merged 6 commits into from Jun 17, 2021
Merged

feat(bigquery): support nullable params and geography params #4225

merged 6 commits into from Jun 17, 2021

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Jun 7, 2021 •
edited

Details:

  • Support the passing of Null values for query parameters.

  • Add support for GEOGGRAPHY param type, which was added after the initial
    GEOGRAPHY type support launched.

Fixes: #4146

@shollyman
feat(bigquery): support nullable params, geography params
72a80c1 
Details:
* Support the passing of Null<type> values for query parameters.

* Add support for GEOGGRAPHY param type, which was added after the initial
  GEOGRAPHY type support launched.

This PR made possible by a couple of cross-country flights without wifi.
@shollyman
Merge branch 'master' into fr-nullparams
002852f
@shollyman
update TODO
b9e89c5
@shollyman shollyman requested a review from a team as a code owner June 7, 2021 01:58
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jun 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2021
@shollyman shollyman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 7, 2021
@shollyman shollyman requested a review from hongalex June 7, 2021 02:03
@shollyman
Copy link
Contributor Author

Revamping this currently, value propagation had some issues

@shollyman shollyman removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 16, 2021
@shollyman shollyman requested review from codyoss and tbpg June 16, 2021 16:44
tbpg
tbpg approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would prefer two smaller PRs in the future. 😄

@shollyman
Copy link
Contributor Author

Looks good to me, but would prefer two smaller PRs in the future. 😄

Reasonable request. :)

My rationale was that the delta from geography was small, and touched all the same areas so I lumped them together this time.

@shollyman shollyman changed the title feat(bigquery): support nullable params, geography params feat(bigquery): support nullable params and geography params Jun 17, 2021
@shollyman shollyman changed the title feat(bigquery): support nullable params and geography params feat(bigquery): support nullable params and geography params Jun 17, 2021
@shollyman shollyman merged commit 43755d3 into googleapis:master Jun 17, 2021
@shollyman shollyman deleted the fr-nullparams branch June 17, 2021 18:16
@shollyman shollyman mentioned this pull request Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

@tbpg tbpg tbpg approved these changes

@codyoss codyoss Awaiting requested review from codyoss

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigquery: Can't send NULL as bigquery.QueryParameter
3 participants
@shollyman @hongalex @tbpg