Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery: support GEOGRAPHY type #11124

Closed
shollyman opened this issue Apr 7, 2021 · 2 comments · Fixed by #13159
Closed

bigquery: support GEOGRAPHY type #11124

shollyman opened this issue Apr 7, 2021 · 2 comments · Fixed by #13159
Assignees
@quartzmo
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@shollyman
Copy link

This issue tracks support for the GEOGRAPHY data type in the bigquery library. It seems this didn't get formally introduced during initial launch.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Apr 7, 2021
@shollyman shollyman mentioned this issue Apr 7, 2021
Merged
@quartzmo quartzmo added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 7, 2021
@quartzmo
Copy link
Member

quartzmo commented Apr 7, 2021

@shollyman Is there a reference implementation for this feature in another language that you prefer?

@shollyman
Copy link
Author

I'm most familiar with the go version. googleapis/google-cloud-go#4225 was an update that improved geography support in query params (initially geography wasn't supported), and has reasonable roundtrip testing.

@quartzmo quartzmo mentioned this issue Jul 27, 2021
Merged
quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this issue Jul 29, 2021
@quartzmo
feat(bigquery): Add support for GEOGRAPHY type
1374c90 
closes: googleapis#11124
@quartzmo quartzmo mentioned this issue Aug 3, 2021
Closed
quartzmo added a commit that referenced this issue Aug 10, 2021
@quartzmo
feat(bigquery): Add support for GEOGRAPHY type
33c39a2 
* Add Schema#geography

closes: #11124
pr: #13159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quartzmo quartzmo

Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bigquery): Add support for GEOGRAPHY type quartzmo/google-cloud-ruby
2 participants
@quartzmo @shollyman