Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compute/metadata): remove leading slash for Get suffix #2760

Merged
merged 3 commits into from Aug 21, 2020
Merged

fix(compute/metadata): remove leading slash for Get suffix #2760

merged 3 commits into from Aug 21, 2020

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Aug 20, 2020

Updates #2750

@codyoss codyoss requested a review from tbpg as a code owner August 20, 2020 19:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2020
tbpg
tbpg suggested changes Aug 20, 2020
View reviewed changes
compute/metadata/metadata.go Show resolved Hide resolved
@codyoss codyoss mentioned this pull request Aug 20, 2020
Closed
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Aug 21, 2020
@codyoss
Revert "use path.Join"
94f1d49 
This reverts commit 77848ca.
tbpg
tbpg approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the churn!

@codyoss codyoss merged commit f0d605c into googleapis:master Aug 21, 2020
@codyoss codyoss deleted the slash branch August 21, 2020 16:44
tritone pushed a commit to tritone/google-cloud-go that referenced this pull request Aug 25, 2020
@codyoss @tritone
fix(compute/metadata): remove leading slash for Get suffix (googleapi…
6d4ec34 
…s#2760)

Updates googleapis#2750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

Assignees
No one assigned
Labels
api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codyoss @tbpg