fix(run/authentication): url encode query parameters #1665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
api: run
tbpg
requested changes
Aug 21, 2020
| v := url.Values{} | ||
| v.Set("audience", serviceURL) | ||
| // query the id_token with audience as the serviceURL | ||
| tokenURL := "/instance/service-accounts/default/identity?" + v.Encode() |
There was a problem hiding this comment.
Is this the API we want for users? Should they be expected to URL encode? I think so...
There was a problem hiding this comment.
Is this the API we want for users?
It feels like it could be better, but without passing an explicit url.Values I am not sure how.
Should they be expected to URL encode?
I think so too. Perhaps we should call this out in the godoc explicitly for Get. "All query parameters are expected to to url encoded.". Thoughts?
There was a problem hiding this comment.
So, with our learnings from the linked issue I don't think we need to do this. Closing.
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
|
This sample is slated for deletion in September, in favor of the planned reuse of the Cloud Functions sample. Action pending docs changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: googleapis/google-cloud-go#2760