Skip to content

Commit

Permalink
docs: update release instructions to reflect latest process (#3052)
Browse files Browse the repository at this point in the history
  • Loading branch information
@0xSage
0xSage committed Oct 20, 2020
1 parent 9a2289c commit b5b7915
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions RELEASING.md
View file
Expand Up @@ -64,7 +64,7 @@ the failures have been resolved.
[continuous Kokoro build](http://go/google-cloud-go-continuous). If there are any
failures in the most recent build, address them before proceeding with the
release.
1. Navigate to `~/code/gocloud/` and switch to master.
1. Navigate to `google-cloud-go/` and switch to master.
1. `git pull`
1. Run `git tag -l | grep -v beta | grep -v alpha` to see all existing releases.
The current latest tag `$CV` is the largest tag. It should look something
Expand All @@ -76,8 +76,9 @@ the failures have been resolved.
(the `git log` is going to show you things in submodules, which are not going
to be part of your release).
1. Edit `CHANGES.md` to include a summary of the changes.
1. `cd internal/version && go generate && cd -`
1. Commit the changes, push to your fork, and create a PR.
1. In `internal/version/version.go`, update `const Repo` to today's date with the format `YYYYMMDD`.
1. In `internal/version` run `go generate`.
1. Commit the changes, ignoring the generated `.go-r` file. Push to your fork, and create a PR titled `chore: release $NV`.

This comment has been minimized.

Sign in to view

Copy link
@hongalex

hongalex Oct 29, 2020

Member

Ah, I actually had this problem before too. The issue was actually Mac specific (I think it was because sed is different than gnu-sed). Otherwise, running go generate should work.

Specifically, I fixed this by running brew install gnu-sed and prepending my PATH with brew's bin so it runs before the mac default sed. For more info see here

This comment has been minimized.

Sign in to view

Copy link
@codyoss

codyoss Oct 29, 2020

Member

Thanks for this, need to re-evaluate the whole version thing in the future. As Tyler pointed out to me a few weeks ago, we update the file but it is in a different module. So the version of google-cloud-go a sub-module depends on will have a different version.
1. Wait for the PR to be reviewed and merged. Once it's merged, and without
merging any other PRs in the meantime:
a. Switch to master.
Expand Down Expand Up @@ -109,7 +110,7 @@ To release a submodule:
failures in the most recent build, address them before proceeding with the
release. (This applies even if the failures are in a different submodule from the one
being released.)
1. Navigate to `~/code/gocloud/` and switch to master.
1. Navigate to `google-cloud-go/` and switch to master.
1. `git pull`
1. Run `git tag -l | grep datastore | grep -v beta | grep -v alpha` to see all
existing releases. The current latest tag `$CV` is the largest tag. It
Expand All @@ -118,8 +119,9 @@ To release a submodule:
1. On master, run `git log $CV.. -- datastore/` to list all the changes to the
submodule directory since the last release.
1. Edit `datastore/CHANGES.md` to include a summary of the changes.
1. `cd internal/version && go generate && cd -`
1. Commit the changes, push to your fork, and create a PR.
1. In `internal/version/version.go`, update `const Repo` to today's date with the format `YYYYMMDD`.
1. In `internal/version` run `go generate`.
1. Commit the changes, ignoring the generated `.go-r` file. Push to your fork, and create a PR titled `chore(datastore): release $NV`.
1. Wait for the PR to be reviewed and merged. Once it's merged, and without
merging any other PRs in the meantime:
a. Switch to master.
Expand Down

0 comments on commit b5b7915

Please sign in to comment.