Skip to content

Commit

Permalink
feat(bigtable): attempt DirectPath by default
Browse files Browse the repository at this point in the history
  • Loading branch information
mohanli-ml committed Oct 30, 2020
1 parent 16e0cb4 commit b3ee65b
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions bigtable/bigtable.go
Expand Up @@ -30,6 +30,7 @@ import (
"github.com/golang/protobuf/proto"
gax "github.com/googleapis/gax-go/v2"
"google.golang.org/api/option"
"google.golang.org/api/option/internaloption"
gtransport "google.golang.org/api/transport/grpc"
btpb "google.golang.org/genproto/googleapis/bigtable/v2"
"google.golang.org/grpc"
Expand All @@ -38,8 +39,10 @@ import (
"google.golang.org/grpc/status"
)

const prodAddr = "bigtable.googleapis.com:443"

const (
prodAddr = "bigtable.googleapis.com:443"
attemptDirectPath = true
)
// Client is a client for reading and writing data to tables in an instance.
//
// A Client is safe to use concurrently, except for its Close method.
Expand Down Expand Up @@ -79,7 +82,9 @@ func NewClientWithConfig(ctx context.Context, project, instance string, config C
option.WithGRPCDialOption(grpc.WithDefaultCallOptions(grpc.MaxCallSendMsgSize(1<<28), grpc.MaxCallRecvMsgSize(1<<28))),
// TODO(grpc/grpc-go#1388) using connection pool without WithBlock
// can cause RPCs to fail randomly. We can delete this after the issue is fixed.
option.WithGRPCDialOption(grpc.WithBlock()))
option.WithGRPCDialOption(grpc.WithBlock()),
// Attempt DirectPath by default
internaloption.EnableDirectPath(attemptDirectPath))
o = append(o, opts...)
connPool, err := gtransport.DialPool(ctx, o...)
if err != nil {
Expand Down

0 comments on commit b3ee65b

Please sign in to comment.