We decided to remove the 1 MiB per-message publish limit

googleapis · Dec 9, 2020 · 8d42ca8 · 8d42ca8
1 parent 007441b
commit 8d42ca8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/pubsublite/internal/wire/errors.go b/pubsublite/internal/wire/errors.go
@@ -26,7 +26,7 @@ var (
 
 	// ErrOversizedMessage indicates that the user published a message over the
 	// allowed serialized byte size limit. It is wrapped in another error.
-	ErrOversizedMessage = fmt.Errorf("maximum allowed message size is MaxPublishMessageBytes (%d)", MaxPublishMessageBytes)
+	ErrOversizedMessage = fmt.Errorf("maximum allowed message size is MaxPublishRequestBytes (%d)", MaxPublishRequestBytes)
 
 	// ErrServiceUninitialized indicates that a service (e.g. publisher or
 	// subscriber) cannot perform an operation because it is uninitialized.

diff --git a/pubsublite/internal/wire/publish_batcher.go b/pubsublite/internal/wire/publish_batcher.go
@@ -110,7 +110,7 @@ func newPublishMessageBatcher(settings *PublishSettings, partition int, onNewBat
 func (b *publishMessageBatcher) AddMessage(msg *pb.PubSubMessage, onResult PublishResultFunc) error {
 	msgSize := proto.Size(msg)
 	switch {
-	case msgSize > MaxPublishMessageBytes:
+	case msgSize > MaxPublishRequestBytes:
 		return xerrors.Errorf("pubsublite: serialized message size is %d bytes: %w", msgSize, ErrOversizedMessage)
 	case msgSize > b.availableBufferBytes:
 		return ErrOverflow

diff --git a/pubsublite/internal/wire/publish_batcher_test.go b/pubsublite/internal/wire/publish_batcher_test.go
@@ -146,7 +146,7 @@ func makeMsgHolder(msg *pb.PubSubMessage, receiver ...*testPublishResultReceiver
 }
 
 func TestPublishBatcherAddMessage(t *testing.T) {
-	const initAvailableBytes = MaxPublishMessageBytes + 1
+	const initAvailableBytes = MaxPublishRequestBytes
 	settings := DefaultPublishSettings
 	settings.BufferedByteLimit = initAvailableBytes
 
@@ -178,8 +178,8 @@ func TestPublishBatcherAddMessage(t *testing.T) {
 	})
 
 	t.Run("oversized message", func(t *testing.T) {
-		msg := &pb.PubSubMessage{Data: bytes.Repeat([]byte{'0'}, MaxPublishMessageBytes)}
-		if gotErr, wantMsg := batcher.AddMessage(msg, nil), "MaxPublishMessageBytes"; !test.ErrorHasMsg(gotErr, wantMsg) {
+		msg := &pb.PubSubMessage{Data: bytes.Repeat([]byte{'0'}, MaxPublishRequestBytes)}
+		if gotErr, wantMsg := batcher.AddMessage(msg, nil), "MaxPublishRequestBytes"; !test.ErrorHasMsg(gotErr, wantMsg) {
 			t.Errorf("AddMessage(%v) got err: %v, want err msg: %q", msg, gotErr, wantMsg)
 		}
 	})

diff --git a/pubsublite/ps/publisher.go b/pubsublite/ps/publisher.go
@@ -33,7 +33,7 @@ var (
 	ErrOverflow = bundler.ErrOverflow
 
 	// ErrOversizedMessage is set for a PublishResult when a published message
-	// exceeds MaxPublishMessageBytes.
+	// exceeds MaxPublishRequestBytes.
 	ErrOversizedMessage = bundler.ErrOversizedItem
 
 	// ErrPublisherStopped is set for a PublishResult when a message cannot be
@@ -55,7 +55,7 @@ func translateError(err error) error {
 }
 
 // PublisherClient is a Cloud Pub/Sub Lite client to publish messages to a given
-// topic.
+// topic. A PublisherClient is safe to use from multiple goroutines.
 //
 // See https://cloud.google.com/pubsub/lite/docs/publishing for more information
 // about publishing.