Skip to content

Commit

Permalink
test(bigquery/storage/managedwriter): address flakiness (#4546)
Browse files Browse the repository at this point in the history
Test was out of sync with comments.  Moved the append out of the loop.
  • Loading branch information
shollyman committed Aug 3, 2021
1 parent d571c6f commit 653b82b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions bigquery/storage/managedwriter/integration_test.go
Expand Up @@ -203,11 +203,11 @@ func testDefaultStream(ctx context.Context, t *testing.T, mwClient *Client, bqCl
if err != nil {
t.Errorf("failed to marshal message %d: %v", k, err)
}
data := append(data, b)
results, err = ms.AppendRows(ctx, data, NoStreamOffset)
if err != nil {
t.Errorf("grouped-row append failed: %v", err)
}
data = append(data, b)
}
results, err = ms.AppendRows(ctx, data, NoStreamOffset)
if err != nil {
t.Errorf("grouped-row append failed: %v", err)
}
// wait for the result to indicate ready, then validate again. Our total rows have increased, but
// cardinality should not.
Expand Down

0 comments on commit 653b82b

Please sign in to comment.