Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
firestore: add ProjectiD detection with sentinel value
Following suit with CL 38450, this change adds ProjectID detection with the sentinel value "*detect-project-id*" which when used to create a NewClient will make resolution of the projectID from the Application Default Credentials (ADC). This CL also fixes a datastore.TestDetectProjectID which had a condition that would panic if err == nil and didn't actually check if a mismatched error message. Updates #1294 Change-Id: I95caac31dc867a5e7f390b47daeb5dfb7368a5de Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/39550 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Jean de Klerk <deklerk@google.com>
- Loading branch information
Showing
4 changed files
with
59 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters