Skip to content

Commit

Permalink
chore(pubsub): fix small lingering TODO comments (#4004)
Browse files Browse the repository at this point in the history
* fix(pubsub): fix failing message storage policy tests

* chore(pubsub): fix small lingering TODO comments

* revert to strings.Replace
  • Loading branch information
hongalex committed Jun 9, 2021
1 parent 7be0af6 commit 16d4b72
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions pubsub/integration_test.go
Expand Up @@ -1603,10 +1603,7 @@ func TestIntegration_BadEndpoint(t *testing.T) {
func TestIntegration_Filter_CreateSubscription(t *testing.T) {
t.Parallel()
ctx := context.Background()
// TODO(hongalex): Remove this once filtering is GA.
// https://github.com/googleapis/google-cloud-go/issues/2390
opts := withGRPCHeadersAssertion(t, option.WithEndpoint("staging-pubsub.sandbox.googleapis.com:443"))
client := integrationTestClient(ctx, t, opts...)
client := integrationTestClient(ctx, t)
defer client.Close()
topic, err := client.CreateTopic(ctx, topicIDs.New())
if err != nil {
Expand Down

0 comments on commit 16d4b72

Please sign in to comment.