Implement "where not equal" and "where not in" Firestore queries #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
(This is to take advantage of the new "not equal" query operators.)
(Note that this doesn't perform the same kind of precondition as the corresponding Java code, to be consistent with the rest of the API. There are a few things where we let the server perform the rejection rather than doing it in the SDK.)
jskeet
force-pushed
the
firestore-queries
branch
from
4a152a2
to
c7bdffc
Compare
|
Thanks folks. Will leave this open for a little while in case the Firestore team want to review too. |
schmidt-sebastian
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5394.
Equivalent Java PR is googleapis/java-firestore#350