Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Get the project_id from gcloud #479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JamshedVesuna
Copy link

@JamshedVesuna JamshedVesuna commented Mar 5, 2024

I think the spirit of 9902503 was to prevent gcloud from popping out of the console and hanging. Unfortunately, this will always close the subprocess and return an empty string.

This causes downstream issues, for example when initializing a new BigQuery client [0] that relies on the credential to carry the project_id.

Adding --quiet will disable interactive prompts and either attempt to use defaults or error.

  1. https://github.com/googleapis/google-cloud-ruby/blob/main/google-cloud-bigquery/lib/google/cloud/bigquery.rb

@JamshedVesuna JamshedVesuna requested a review from a team as a code owner March 5, 2024 22:15
Copy link

google-cla bot commented Mar 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@JamshedVesuna
Copy link
Author

Hi, is it possible to get a review for this? I have signed the Contributor License Agreement. Thank you! @dazuma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant