New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for AWS Workload Identity Federation #418

Merged

bajajneha27 merged 20 commits into googleapis:main from BigTailWolf:aws-creds

Mar 21, 2023

Contributor

BigTailWolf commented Mar 17, 2023

This is a wrap of #414

Will continue fix on this one.

BigTailWolf requested a review from a team as a code owner

March 17, 2023 04:30

conventional-commit-lint-gcf bot commented Mar 17, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/


          feat: AWS Credntial. Wrap all Ryan & Robert's change

a4acba7

BigTailWolf force-pushed the aws-creds branch 4 times, most recently from 32657d9 to 8b5d952 Compare

March 18, 2023 06:42


          expose project_id method

ba8349e

BigTailWolf force-pushed the aws-creds branch from 8b5d952 to ba8349e Compare

March 18, 2023 07:37

BigTailWolf added 3 commits

March 18, 2023 18:21


          fix some comment style

98ef6c1


          fix linting


          squeez the lines of module

a657817

bajajneha27 reviewed

View reviewed changes

lib/googleauth/external_account.rb Show resolved Hide resolved

lib/googleauth/external_account/aws_credentials.rb Outdated Show resolved Hide resolved

lib/googleauth/external_account/base_credentials.rb Outdated Show resolved Hide resolved

lib/googleauth/helpers/connection.rb Outdated Show resolved Hide resolved

lib/googleauth/oauth2/sts_client.rb Outdated Show resolved Hide resolved

lib/googleauth/external_account/base_credentials.rb Outdated Show resolved Hide resolved

BigTailWolf and others added 7 commits

March 19, 2023 23:21


          Update lib/googleauth/external_account.rb

b23ce5b

Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>


          Update lib/googleauth/external_account/aws_credentials.rb

7cbd5b7

Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>


          Update lib/googleauth/external_account/base_credentials.rb

4a66571

Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>


          Update lib/googleauth/helpers/connection.rb

e3ee5c9

Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>


          Update lib/googleauth/oauth2/sts_client.rb

9bede4b

Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>


          Update lib/googleauth/external_account/base_credentials.rb

050b069

Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>


          remove empty

c63098e

dazuma approved these changes

View reviewed changes

Member

dazuma left a comment

I'm assuming the logic is sound and the functionality is tested. I'm suggesting some fixes to documentation formatting so it gets rendered correctly in Ruby's documentation generator, and a few idiomatic Ruby tweaks. Otherwise it looks good to go.

lib/googleauth/credentials.rb Outdated Show resolved Hide resolved

lib/googleauth/service_account.rb Outdated Show resolved Hide resolved

lib/googleauth/external_account/base_credentials.rb Outdated Show resolved Hide resolved

lib/googleauth/external_account/aws_credentials.rb Outdated Show resolved Hide resolved

lib/googleauth/external_account/aws_credentials.rb Outdated Show resolved Hide resolved

lib/googleauth/external_account/aws_credentials.rb Outdated Show resolved Hide resolved

lib/googleauth/external_account/aws_credentials.rb Show resolved Hide resolved

lib/googleauth/external_account/base_credentials.rb Outdated Show resolved Hide resolved

lib/googleauth/oauth2/sts_client.rb Outdated Show resolved Hide resolved

lib/googleauth/external_account/base_credentials.rb Outdated Show resolved Hide resolved

BigTailWolf added 3 commits

March 21, 2023 02:54


          address the comments of Ruby code style

6b44904


          fix the trailing whitespaces

2cb3f1b


          fix the normalized string method

5e0570d

bajajneha27 approved these changes

View reviewed changes

lib/googleauth/external_account/base_credentials.rb Outdated Show resolved Hide resolved

spec/googleauth/external_account/aws_credentials_spec.rb Outdated Show resolved Hide resolved

spec/googleauth/external_account/aws_request_signer_spec.rb Show resolved Hide resolved

spec/googleauth/external_account_spec.rb Outdated Show resolved Hide resolved

spec/googleauth/oauth2/sts_client_spec.rb Outdated Show resolved Hide resolved

BigTailWolf and others added 5 commits

March 20, 2023 21:56


          Update lib/googleauth/external_account/base_credentials.rb

e406859

Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>


          Update spec/googleauth/external_account/aws_credentials_spec.rb

34f24b1

Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>


          Update spec/googleauth/external_account_spec.rb

fb91d8a

Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>


          Update spec/googleauth/oauth2/sts_client_spec.rb

662c3d7

Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>


          adding the copyright section

97e22c0

Contributor

bajajneha27 commented Mar 21, 2023

feat: Add support for AWS Workload Identity Federation

bajajneha27 merged commit 1354b07 into googleapis:main

shivgautam changed the title ~~feat: aws credential. Wrap all Ryan & Robert's change~~ feat: Add support for AWS Workload Identity Federation

yoshi-code-bot mentioned this pull request

chore(main): release googleauth 1.5.0 #419

Merged

NeoCat commented Mar 22, 2023

I found an issue around fetching token with IMDSv2. I appreciate if you would take a look at PR #421 to address this issue.

Contributor

bajajneha27 commented Mar 23, 2023

Thanks for bringing this to our notice. We're looking at it. Let me get back to you on that.

bajajneha27 mentioned this pull request

feat: Add AWS Workload Identity Federation Support #386

Closed

w32-blaster mentioned this pull request

How can I authenticate using Workload identity federation? #354

Open

mmizutani mentioned this pull request

Add support for AWS ECS container credentials endpoint for external account authentication #422

Closed

wyardley mentioned this pull request

Support Workload Identity Federation authentication inspec/inspec-gcp#433

Open

BigTailWolf deleted the aws-creds branch

June 20, 2023 17:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment