Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squashed work of AWS support. #417

Closed
wants to merge 1 commit into from
Closed

Conversation

BigTailWolf
Copy link
Contributor

  • feat: Add External Account Credential support as well as support for impersonated credential

  • chore: Add tests for ExternalAccount, add methods required to make test compatible with apply_auth_examples. ExternalAccount was not fully compatible with the other providers, this brings it in line and moves some common methods between the other provides and ExternalAccount into a module which is now included by the AWSClient provider and Signet::Auth::Client

  • chore: Move AWS Credentials to their own file, do not pass role from external account, create dedicated Connection helper module, other misc PR cleanup

  • chore: Update BaseClient documentation comment

  • chore: Ensure the subject token type matches AWS before building AwsCredentials

  • feat: perform validation and add tests

  • Fixes to get manual testing working

  • dates

  • fixes

  • Allow different versions of Faraday

  • ALlow different versions of Faraday

  • chore: use SampleLoader for running sample tests (chore: use SampleLoader for running sample tests #411)

  • address the comments


* feat: Add External Account Credential support as well as support for impersonated credential

* chore: Add tests for ExternalAccount, add methods required to make test compatible with apply_auth_examples. ExternalAccount was not fully compatible with the other providers, this brings it in line and moves some common methods between the other provides and ExternalAccount into a module which is now included by the AWSClient provider and Signet::Auth::Client

* chore: Move AWS Credentials to their own file, do not pass role from external account, create dedicated Connection helper module, other misc PR cleanup

* chore: Update BaseClient documentation comment

* chore: Ensure the subject token type matches AWS before building AwsCredentials

* feat: perform validation and add tests

* Fixes to get manual testing working

* dates

* fixes

* Allow different versions of Faraday

* ALlow different versions of Faraday

* chore: use SampleLoader for running sample tests (googleapis#411)

* address the comments

---------

Co-authored-by: Robert Clark <robert.clark@kirkpatrickprice.com>
Co-authored-by: Robert Clark <rbclarkdev@gmail.com>
Co-authored-by: Ryan Kohler <ryan.c.kohler@gmail.com>
Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>
@BigTailWolf BigTailWolf requested a review from a team as a code owner March 15, 2023 23:37
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@google-cla
Copy link

google-cla bot commented Mar 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@BigTailWolf BigTailWolf deleted the aws branch March 15, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant